Fix #30408: Fallback to string index signature for literal and generic indexing#62925
Open
mhughes2012 wants to merge 3 commits intomicrosoft:mainfrom
Open
Fix #30408: Fallback to string index signature for literal and generic indexing#62925mhughes2012 wants to merge 3 commits intomicrosoft:mainfrom
mhughes2012 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
…nd generic indexing Ensure that string literal indexing and type parameters constrained to string correctly fall back to an available string index signature if a specific property is not found. This prevents confusing 'any' or 'missing property' errors when a valid indexer exists.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30408
Description
This PR addresses issue #30408 where indexing an object with a string literal or a generic type parameter constrained to
stringwould fail to fall back to an available string index signature if a specific property was not found. This often resulted inanytypes or confusing "property missing" errors even when a valid index signature existed.The change modifies the property lookup logic in
src/compiler/checker.tsto:string.Checklist
Backlogmilestonemainbranchhereby runtestslocallyTest Case
I have added a new compiler test case
tests/cases/compiler/stringLiteralIndexingWithIndexSignature.tswhich validates:K extends string) correctly resolving to the index signature's type.